connector widget: do not modify ini fail on connection failure + connection editing - Githubissues

ploomber / jupysql-plugin

BSD 3-Clause "New" or "Revised" License

16 stars 12 forks source link

connector widget: do not modify ini fail on connection failure + connection editing #70

Closed edublancas closed 1 year ago

edublancas commented 1 year ago

Describe your changes

Issue number

Closes https://github.com/ploomber/jupysql-plugin/issues/68
Closes https://github.com/ploomber/jupysql-plugin/issues/61
More UI tests
Add ConnectorWidgetManager to manage the widget <> connection file status

Checklist before requesting a review

[ ] Performed a self-review of my code
[ ] Formatted my code with pkgmt format
[ ] Added tests (when necessary).
[ ] Added docstring documentation and update the changelog (when needed)

edublancas commented 1 year ago

@yafimvo please review again

yafimvo commented 1 year ago

lg