76 Add formatter for JavaScript/TypeScript files

ploomber / jupysql-plugin

BSD 3-Clause "New" or "Revised" License

16 stars 12 forks source link

76 Add formatter for JavaScript/TypeScript files #79

Closed bryannho closed 1 year ago

bryannho commented 1 year ago

Describe your changes

added config to enable eslint

Issue number

Closes #76

Checklist before requesting a review

[ ] Performed a self-review of my code
[ ] Formatted my code with pkgmt format
[ ] Added tests (when necessary).
[ ] Added docstring documentation and update the changelog (when needed)

bryannho commented 1 year ago

eslint was already included in the package.json so I simply created a config file with npm init @eslint/config. If we want to use a newer version of eslint I can update it in the package.json

edublancas commented 1 year ago

can you check the CI? Looks like since we added this, now the linter is running automatically.

bryannho commented 1 year ago

can you check the CI? Looks like since we added this, now the linter is running automatically.

It looks like it's running pkgmt lint as defined in ci.yaml but not eslint as I didn't modify ci.yaml to include that. Was this the intended behavior?

bryannho commented 1 year ago

the CI test failed on my first commit because of the edit I made to tsconfig.json but now it seems to be failing because of an issue with widgets.ipynb. is this related to the issue with @jupyter-widgets/base?

bryannho commented 1 year ago

@edublancas could you please review? just pinging in case you weren't notified