Closed edublancas closed 11 months ago
Please review this PR: https://github.com/conda-forge/staged-recipes/pull/24656 If it's fine I'll request a review from conda maintainers @edublancas
@neelasha23 lgtm. once this is in conda, please install it from there in a new environment to ensure it works correctly
Sure!
Please add a comment in the PR so that I can tick GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
@edublancas
@neelasha23 the recipe has been merged: https://github.com/conda-forge/staged-recipes/pull/24656
please do a quick test by installing jupysql-plugin from conda and checking that things work (the connection manager, the share notebook button, sql formatting, autocompletion, etc).
if all works, we can close this
Getting error for all the features:
@edublancas
Only the ConnectorWidget seems to be working:
@edublancas
I think the errors you're getting are because you're using JupyterLab 4, please try again with JupyterLab 4
Features are working fine:
Connector Widget:
New connection:
SQL Formatting:
Autocomplete:
notebook share:
However I see that it is asking for creating an account? Is it expected? I didn't get any prompt for API key:
@edublancas
that's fine. it won't prompt you for an API key if you set one already. we can close this then
since jupysql-plugin is now a hard dependency for jupysql, we need to create a conda recipe for jupysql-plugin.
since jupysql-plugin is not available on conda, the PR for the new jupysql is broken: https://github.com/conda-forge/jupysql-feedstock/pull/21#issuecomment-1731748251
there is some information on how to upload packages to conda here: https://github.com/search?q=repo%3Aploomber%2Fcontributing%20conda&type=code