ploomber / jupysql-plugin

BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

create conda recipe #84

Closed edublancas closed 11 months ago

edublancas commented 1 year ago

since jupysql-plugin is now a hard dependency for jupysql, we need to create a conda recipe for jupysql-plugin.

since jupysql-plugin is not available on conda, the PR for the new jupysql is broken: https://github.com/conda-forge/jupysql-feedstock/pull/21#issuecomment-1731748251

there is some information on how to upload packages to conda here: https://github.com/search?q=repo%3Aploomber%2Fcontributing%20conda&type=code

neelasha23 commented 12 months ago

Please review this PR: https://github.com/conda-forge/staged-recipes/pull/24656 If it's fine I'll request a review from conda maintainers @edublancas

edublancas commented 12 months ago

@neelasha23 lgtm. once this is in conda, please install it from there in a new environment to ensure it works correctly

neelasha23 commented 12 months ago

Sure! Please add a comment in the PR so that I can tick GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there. @edublancas

edublancas commented 11 months ago

@neelasha23 the recipe has been merged: https://github.com/conda-forge/staged-recipes/pull/24656

please do a quick test by installing jupysql-plugin from conda and checking that things work (the connection manager, the share notebook button, sql formatting, autocompletion, etc).

if all works, we can close this

neelasha23 commented 11 months ago

Getting error for all the features:

Screenshot 2023-12-15 at 1 23 51 AM Screenshot 2023-12-15 at 1 23 58 AM

@edublancas

neelasha23 commented 11 months ago

Only the ConnectorWidget seems to be working:

Screenshot 2023-12-15 at 1 33 12 AM

@edublancas

edublancas commented 11 months ago

I think the errors you're getting are because you're using JupyterLab 4, please try again with JupyterLab 4

neelasha23 commented 11 months ago
Screenshot 2023-12-15 at 3 20 07 PM

Features are working fine:

Connector Widget:

Screenshot 2023-12-15 at 3 08 42 PM

New connection:

Screenshot 2023-12-15 at 3 17 36 PM

SQL Formatting:

Screenshot 2023-12-15 at 3 10 05 PM

Autocomplete:

Screenshot 2023-12-15 at 3 11 17 PM

notebook share:

Screenshot 2023-12-15 at 3 11 31 PM

However I see that it is asking for creating an account? Is it expected? I didn't get any prompt for API key:

Screenshot 2023-12-15 at 3 11 59 PM

@edublancas

edublancas commented 11 months ago

that's fine. it won't prompt you for an API key if you set one already. we can close this then