ploomber / jupysql-plugin

BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Deploy notebook fix #90

Closed neelasha23 closed 1 year ago

neelasha23 commented 1 year ago

Describe your changes

  1. Modified ploomber cloud endpoint
  2. Added project_id to endpoint when redeploying.

Issue number

Closes #88

Checklist before requesting a review

neelasha23 commented 1 year ago

This is the output when Deploy Notebook is clicked second time after first deployment. Subsequent clicks on the button deploys the notebook again. Please confirm if this is the expected behaviour @edublancas

(I'm fixing the CI)

Screenshot 2023-11-28 at 5 55 37 PM
edublancas commented 1 year ago

@neelasha23 did you verify that the notebook is successfully deployed on ploomber cloud? and that modifying the notebook and clicking again successfully redeploys?

neelasha23 commented 1 year ago
  1. In the first deployment project is getting created , I've verified the dashboard successfully deployed.
  2. Even if there are no changes in the notebook and Deploy Notebook is clicked it creates a fresh deployment with a new project ID. I don't think there is a check to detect if notebook got changed?

Also, there are a lot of 404 errors in the CI and the tests are timing out and eventually failing. The deploy notebook tests have passed in my local.

@edublancas

edublancas commented 1 year ago

Even if there are no changes in the notebook and Deploy Notebook is clicked it creates a fresh deployment with a new project ID. I don't think there is a check to detect if notebook got changed?

we haven't implemented logic to detect if the notebook is changed so that's expected. what's not expected is that if you deploy the notebook and then click again on "deploy", it should keep the same project ID, because the first time you deploy, we modify the notebook file and add the project id. check the logic, I think it might be due to changes in the API

Also, there are a lot of 404 errors in the CI and the tests are timing out and eventually failing. The deploy notebook tests have passed in my local.

yeah we have some intermittent failures but looks like the CI passed now

neelasha23 commented 1 year ago

Fixed the code. Now it's redeploying to the same project_id. PFB screenshots for a sample notebook:

Screenshot 2023-11-29 at 5 12 02 PM

Dashboard: https://dawn-art-9975.ploomberapp.io/

@edublancas

neelasha23 commented 1 year ago

Where should I add changelog entry? 0.2.6 or create a new header? @edublancas

edublancas commented 1 year ago

you need to create a new header section. but no worries, I'll take it from here