ploomber / jupysql-plugin

BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

server app must check http status code #97

Open edublancas opened 11 months ago

edublancas commented 11 months ago

there are a bunch of places where we're making requests but we're not checking that the response code is 200. we should do it and then show an error if the code is != 200

https://github.com/ploomber/jupysql-plugin/blob/a5986a06dcf165d5cbc08711a1bc96901bacdb0a/jupysql_plugin/server_handlers/dashboard.py#L103

we should also add a ui test to ensure that the response error is shown if the code is != 200