ploomber / jupysql

Better SQL in Jupyter. 📊
https://jupysql.ploomber.io
Apache License 2.0
723 stars 76 forks source link

Links broken in auto-generated PR text #1003

Closed laowantong closed 7 months ago

laowantong commented 7 months ago

What happens?

When I open a PR a boilerplate is generated. The generated links seem to be broken, e.g.:

📚 Documentation preview 📚: https://jupysql--1002.org.readthedocs.build/en/1002/

To Reproduce

Just open a PR.

OS:

MacOS

JupySQL Version:

0.10.0

Full Name:

Aristide Grange

Affiliation:

Université de Lorraine

edublancas commented 7 months ago

it's not broken, that's the documentation preview. building the docs takes a few mins so the URL will work until the build is done

laowantong commented 7 months ago

You're right for this link, it is working now. But the other ones yield a 404:

In the case they need several minutes too, a warning would be a plus.

image
edublancas commented 7 months ago

those were indeed broken, fixed them, thanks

https://github.com/ploomber/jupysql/blob/master/.github/pull_request_template.md