ploomber / ploomber-engine

A toolbox 🧰 for Jupyter notebooks 📙: testing, experiment tracking, debugging, profiling, and more!
https://engine.ploomber.io
BSD 3-Clause "New" or "Revised" License
66 stars 14 forks source link

Added error msg to output notebook in case of exception #67

Closed mehtamohit013 closed 1 year ago

mehtamohit013 commented 1 year ago

Describe your changes

Added error messages to the top and above the code where the exception occurs in markdown

Issue ticket number and link

Closes #63

Checklist before requesting a review


:books: Documentation preview :books:: https://ploomber-engine--67.org.readthedocs.build/en/67/

edublancas commented 1 year ago

is this ready for review? don't forget to request the review:

image

mehtamohit013 commented 1 year ago

GitHub still not showing the Reviewer Panel for me :( image

Also, @idomic , below is the papermill and ploomber engine output respectively: Screenshot_2023-03-18_10-25-16 Screenshot_2023-03-18_10-26-26

I don't understand what you earlier commented on issue #63 : "The Cell that failed is also marked with a red and the output is red as well"

idomic commented 1 year ago

@mehtamohit013 this red bolded text is exactly what I meant (so not only top notebook but the actual cell as well). Nice job!