search

ploomber / ploomber-engine

A toolbox 🧰 for Jupyter notebooks 📙: testing, experiment tracking, debugging, profiling, and more!
https://engine.ploomber.io
BSD 3-Clause "New" or "Revised" License
66 stars 14 forks source link

Fix stdout and stderr stream; IO() #68

Open mehtamohit013 opened 1 year ago

mehtamohit013 commented 1 year ago

Currently, when running tqdm and printing inside it, breaks and messes up the output for the user. For now, there is a temporary fix, which adds \n to eliminate this but adds extra new lines. Fix the output and the IO() class in ipython.py

66 #1080 Summary

idomic commented 1 year ago

I believe ploomber itself doesn't use ploomber-engine and we'll probably need to change this to solve #1080

edublancas commented 1 year ago

I believe ploomber itself doesn't use ploomber-engine and we'll probably need to change this to solve https://github.com/ploomber/ploomber/issues/1080

it doesn't use it by default but it can be enabled

idomic commented 1 year ago

Yeah, I think if we want to solve 1080 we have to right?

edublancas commented 1 year ago

Yeah, I think if we want to solve 1080 we have to right?

I quickly looked at the source code. It is possible to use ploomber-engine with ploomber but we need to document it more clearly:

https://github.com/ploomber/ploomber/blob/2a6287f1beea9f51ecbe59ddebac266cef6c77e8/src/ploomber/tasks/notebook.py#LL767C5-L767C5

Currently, if you set the engine_name to debug or debuglater, it'll use ploomber-engine because the original motivation for ploomber-engine was to enable debugging.

With the new features we've added, there are now more reasons for users to switch to ploomber-engine; so I think we should allow engine_name: ploomber-engine to also switch to ploomber engine for notebook execution and document what are the benefits of using it.