Modify --save-profiling-data to accept File Path(Ploomber Engine CLI) - Githubissues

ploomber / ploomber-engine

A toolbox 🧰 for Jupyter notebooks 📙: testing, experiment tracking, debugging, profiling, and more!

https://engine.ploomber.io

BSD 3-Clause "New" or "Revised" License

59 stars 14 forks source link

Modify --save-profiling-data to accept File Path(Ploomber Engine CLI) #78

Closed tonykploomber closed 1 year ago

tonykploomber commented 1 year ago

Describe your changes

Now save_profiling_data can take Path string, also the existing bool usage will be supported as well.

Changes:

Enhance save_profiling_data option to accept Path
Updates doc in API Reference, Memory usage and Cell runtime

Screenshot 2023-05-31 at 3 27 45 PM

Issue number

Closes #65

Checklist before requesting a review

[x] Performed a self-review of my code
[x] Formatted my code with pkgmt format
[x] Added tests (when necessary).
[x] Added docstring documentation and update the changelog (when needed)

:books: Documentation preview :books:: https://ploomber-engine--78.org.readthedocs.build/en/78/

avivajpeyi commented 11 months ago

Hey! this is great, is there a planned pypi release date for 0.0.29dev?

edublancas commented 11 months ago

I forgot to make the release, just did it!

it ended up being 0.0.30 because there was some issue with the package's metadata (0.0.29 failed to upload to PyPI)