ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
455 stars 54 forks source link

adds description for examples #258

Closed ShubhamGawande191 closed 1 year ago

ShubhamGawande191 commented 1 year ago

Describe your changes

Added descriptions for examples, also added a few generic comments in examples, and commented out a few useless things which don't contribute to the actual example.

Issue ticket number and link

Closes #217

Checklist before requesting a review


:books: Documentation preview :books:: https://sklearn-evaluation--258.org.readthedocs.build/en/258/

ShubhamGawande191 commented 1 year ago

examples from which I commented out code: precision_recall_multiclass.py precision_recall.py roc_binary_classification.py roc_comparison.py roc_new_api.py roc.py confusion_matrix.py [haven't commented out yet]

Also, in the src/sklearn_evaluation/plot/roc.py, for the ROCAdd example, I didn't find any roc_add.py. I am guessing it is the same as roc_comparison.py. If it is something different, let me know what do I add there.

edublancas commented 1 year ago

Also, in the src/sklearn_evaluation/plot/roc.py, for the ROCAdd example, I didn't find any roc_add.py. I am guessing it is the same as roc_comparison.py.

yep. ROCAdd is the same as roc_compaison, so no need to add more examples.

edublancas commented 1 year ago

any updates? are you opening another pull request?

ShubhamGawande191 commented 1 year ago

Yes, just now opened a pull request