ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
455 stars 54 forks source link

fixes inline plots in tutorial #260

Closed edublancas closed 1 year ago

edublancas commented 1 year ago

Describe your changes

Issue ticket number and link

Closes #x

Checklist before requesting a review

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4053958523


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sklearn_evaluation/plot/util.py 4 9 44.44%
<!-- Total: 51 56 91.07% -->
Totals Coverage Status
Change from base Build 4053917694: -0.1%
Covered Lines: 2866
Relevant Lines: 3052

💛 - Coveralls
edublancas commented 1 year ago

Where is it documented?

what? the deprecation? It was a pending deprecation, check out the changes

idomic commented 1 year ago

No no I mean this one: no_display_plots Also display_no_plots might be a better name

edublancas commented 1 year ago

Nothing has changed. no_display_plots is a context manager that's only applied when it's needed outside of it, behavior remains the same, check out the implementation

edublancas commented 1 year ago

Can the no_display_plots context affect the user experience when working with notebooks?

no, it won't.no_display_plots is only used when de-serializing plots from JSON stored in a database. We shouldn't display them in such cases since we're loading them to put them in a table-view.

after exiting the context manager all goes back to normal.