ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
455 stars 54 forks source link

Calibration curve #265

Closed neelasha23 closed 1 year ago

neelasha23 commented 1 year ago

Describe your changes

Calibration curve objected-oriented API

Issue ticket number and link

Closes #118

Checklist before requesting a review


:books: Documentation preview :books:: https://sklearn-evaluation--265.org.readthedocs.build/en/265/

idomic commented 1 year ago

Converted to draft as I saw some conflicts, please convert and tag when ready for review.

neelasha23 commented 1 year ago

Sure. The CI is also failing, so will tag once it's sorted out.

edublancas commented 1 year ago

ci has been fixed in master, please rebase

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4112980217


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sklearn_evaluation/plot/calibration.py 105 111 94.59%
<!-- Total: 106 112 94.64% -->
Totals Coverage Status
Change from base Build 4107180724: 0.1%
Covered Lines: 3042
Relevant Lines: 3231

💛 - Coveralls
neelasha23 commented 1 year ago

Resolved the comments @edublancas

edublancas commented 1 year ago

please rebase, there are some conflicts