search

ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
457 stars 54 forks source link

re-add examples/ to CI #305

Closed edublancas closed 1 year ago

edublancas commented 1 year ago

it was removed by mistake on https://github.com/ploomber/sklearn-evaluation/pull/295

edublancas commented 1 year ago

when looking at the logs, I realized that removing the examples/ argument in pytest did not reduce the number of executed tests (362):

before: https://github.com/ploomber/sklearn-evaluation/actions/runs/4236644410/jobs/7361699546 after: https://github.com/ploomber/sklearn-evaluation/actions/runs/4284932945/jobs/7462572384

so I think we can re-add them by splitting in two pytest calls (one that passes the examples/ and another one that passes the other arguments) - the latter can contain the xdist argument

idomic commented 1 year ago

@edublancas not sure why but splitting it into 2 commands made it worse than where we started.

edublancas commented 1 year ago

unless we find a solution, I think we should revert the changes to pre xdist then

idomic commented 1 year ago

This connects to https://github.com/ploomber/contributing/issues/28