Closed Sohlar closed 1 year ago
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/sklearn_evaluation/plot/precision_recall.py | 1 | 98.51% | ||
src/sklearn_evaluation/plot/plot.py | 2 | 72.73% | ||
src/sklearn_evaluation/plot/calibration.py | 6 | 93.02% | ||
src/sklearn_evaluation/plot/roc.py | 6 | 95.11% | ||
<!-- | Total: | 15 | --> |
Totals | |
---|---|
Change from base Build 4463694319: | 0.05% |
Covered Lines: | 3557 |
Relevant Lines: | 3878 |
Hey @Sohlar is this ready for review?
@idomic Not yet, previewing docs and rerunning tests.
@idomic It is ready now!
@Sohlar it doesn't seem ready. Please make sure the CI is passing before tagging for review.
@Sohlar Please mark ready for review once this is ready and CI is passing
FYI: the docs started failing due to an unrelated reason https://github.com/ploomber/sklearn-evaluation/issues/329 we can either wait for a fix or merge without a doc preview
@Sohlar let's see it's passing and we can merge.
Nice work @Sohlar !
Feel free to pick a few more good first issues
Describe your changes
Add docstring example to .SQLitetracker.upsert_append() Modified TrackLossandAccuracyCallback() in nn_tracking.md to use upsert_append()
Issue ticket number and link
Closes #314
Checklist before requesting a review
:books: Documentation preview :books:: https://sklearn-evaluation--317.org.readthedocs.build/en/317/