ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
457 stars 54 forks source link

#314 Docstring Example for .upsert_append() #317

Closed Sohlar closed 1 year ago

Sohlar commented 1 year ago

Describe your changes

Add docstring example to .SQLitetracker.upsert_append() Modified TrackLossandAccuracyCallback() in nn_tracking.md to use upsert_append()

Issue ticket number and link

Closes #314

Checklist before requesting a review


:books: Documentation preview :books:: https://sklearn-evaluation--317.org.readthedocs.build/en/317/

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4562908692

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.


Files with Coverage Reduction New Missed Lines %
src/sklearn_evaluation/plot/precision_recall.py 1 98.51%
src/sklearn_evaluation/plot/plot.py 2 72.73%
src/sklearn_evaluation/plot/calibration.py 6 93.02%
src/sklearn_evaluation/plot/roc.py 6 95.11%
<!-- Total: 15 -->
Totals Coverage Status
Change from base Build 4463694319: 0.05%
Covered Lines: 3557
Relevant Lines: 3878

💛 - Coveralls
idomic commented 1 year ago

Hey @Sohlar is this ready for review?

Sohlar commented 1 year ago

@idomic Not yet, previewing docs and rerunning tests.

Sohlar commented 1 year ago

@idomic It is ready now!

idomic commented 1 year ago

@Sohlar it doesn't seem ready. Please make sure the CI is passing before tagging for review.

neelasha23 commented 1 year ago

@Sohlar Please mark ready for review once this is ready and CI is passing

edublancas commented 1 year ago

FYI: the docs started failing due to an unrelated reason https://github.com/ploomber/sklearn-evaluation/issues/329 we can either wait for a fix or merge without a doc preview

idomic commented 1 year ago

@Sohlar let's see it's passing and we can merge.

idomic commented 1 year ago

Nice work @Sohlar ! Feel free to pick a few more good first issues