ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
455 stars 54 forks source link

migration to jupyter book 0.14 #318

Closed gtduncan closed 1 year ago

gtduncan commented 1 year ago

Describe your changes

Migrates sklearn-evaluation to jupyter-book 0.14 (https://github.com/ploomber/contributing/issues/35)

Issue ticket number and link

Closes x

Checklist before requesting a review


:books: Documentation preview :books:: https://sklearn-evaluation--318.org.readthedocs.build/en/318/

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4438971532

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.


Totals Coverage Status
Change from base Build 4368081770: 0.0%
Covered Lines: 3661
Relevant Lines: 3878

💛 - Coveralls
gtduncan commented 1 year ago

Docs seem to be failing on cell in NotebookCollection.md. An ImportError is being raised for lxml— odd because it looks like it's a dependency in environment.yml. Didn't have this issue locally, maybe it's not being installed in readthedocs run?

nbclient.exceptions.CellExecutionError: An error occurred while executing the following cell:
------------------
nbs["metrics"]
------------------

Raises this:

ImportError: lxml not found, please install it
ImportError: lxml not found, please install it
gtduncan commented 1 year ago

All good now!

edublancas commented 1 year ago

merged this now but opened another issue to tackle the image problem: #323