moving plot's sub and add methods to abstract class

WSShawn commented 1 year ago

Describe your changes

Added a generic implementation for plot sub and add method.
Added unit tests for plot sub and add method.

Issue ticket number and link

Closes #236

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added thorough tests (when necessary).
[x] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://sklearn-evaluation--320.org.readthedocs.build/en/320/

idomic commented 1 year ago

Let's wait for the CI.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4456540706

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.

2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.05%) to 94.453%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/sklearn_evaluation/plot/plot.py	2	4	50.0%
<!--	Total:	2	4	50.0%	-->

Totals
Change from base Build 4368081770:	0.05%
Covered Lines:	3661
Relevant Lines:	3876

💛 - Coveralls

WSShawn commented 1 year ago

CI passed! Sorry for all the back and forth on this issue!

WSShawn commented 1 year ago

@edublancas request for review!

edublancas commented 1 year ago

great!

ploomber / sklearn-evaluation