ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
455 stars 54 forks source link

Adds missing html_meta tags #321

Closed Sohlar closed 1 year ago

Sohlar commented 1 year ago

Describe your changes

Added raw/meta directives for html_meta tags | SEO improvement

Issue ticket number and link

Closes #290

Checklist before requesting a review


:books: Documentation preview :books:: https://sklearn-evaluation--321.org.readthedocs.build/en/321/

idomic commented 1 year ago

@Sohlar it seems you've just used a placeholder in all of those files? The content needs to be correct: This isn't valid:

<meta name="description" lang="en" content="Some description">
    <meta property="og:locale" content="en_US">

.. meta::
   :keywords: Tag1, Tag2

It should be something descriptive of the page with the right keyword tags.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4461796981

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.


Totals Coverage Status
Change from base Build 4368081770: 0.0%
Covered Lines: 3661
Relevant Lines: 3878

💛 - Coveralls
neelasha23 commented 1 year ago

@Sohlar Are you creating a fresh PR?

Sohlar commented 1 year ago

@neelasha23 Yes, I managed my branches incorrectly and had to delete it. I posted a new example for discussion here https://github.com/ploomber/sklearn-evaluation/issues/290#issuecomment-1476059201