ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
455 stars 54 forks source link

Docs Caching #332

Closed neelasha23 closed 1 year ago

neelasha23 commented 1 year ago

Describe your changes

Shortening the docs build time by caching the .jupyter_cache folder in S3 Pinned Keras version as the upgrade was leading to errors

Issue ticket number and link

Closes #329

Checklist before requesting a review


:books: Documentation preview :books:: https://sklearn-evaluation--332.org.readthedocs.build/en/332/

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4668163521

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.


Totals Coverage Status
Change from base Build 4578123439: 0.0%
Covered Lines: 3384
Relevant Lines: 3692

💛 - Coveralls
idomic commented 1 year ago

@neelasha23 how much did it improve it overall? Also, I think you've also fixed this by pinning Keras?

neelasha23 commented 1 year ago

@neelasha23 how much did it improve it overall?

It's 347 secs for the current build. I'm not sure which build to benchmark this against since doc build in all the current open PRs are failing

Also, I think you've also fixed this by pinning Keras?

Yes, that's the error that was coming up.

@idomic

idomic commented 1 year ago

Cool, I think this merged one is a good benchmark. Looks like it's almost 50% (from 527). Nice work!