search

ploomber / sklearn-evaluation

Machine learning model evaluation made easy: plots, tables, HTML reports, experiment tracking and Jupyter notebook analysis.
https://sklearn-evaluation.ploomber.io
Apache License 2.0
455 stars 54 forks source link

Disable version check in sk-eval and Fixing Heteroscedasticity in Regression #333

Closed TegveerG closed 1 year ago

TegveerG commented 1 year ago

Describe your changes

Added PLOOMBER_VERSION_CHECK_DISABLED=true under pre_build: in .readthedocs.yml While doing the above task, I fixed statsmodels functionality by adding it in setup.py and fixed linting for RegressionPlots.ipynb

Issue number

Closes https://github.com/ploomber/contributing/issues/26 Closes #166

Checklist before requesting a review

:books: Documentation preview :books:: https://sklearn-evaluation--333.org.readthedocs.build/en/333/

TegveerG commented 1 year ago

see my comments in: ploomber/ploomber-engine#79 (review)

please start a new PR because this one went bad (there are modified files that shouldn't be modified)

Understood, working on a new PR and discarding heteroscedasticity issue (tried killing 2 birds with 1 stone). The files that shouldn't be modified did so due to pkgmt format and pkgmt lint. For the sklearn-evaluation project, should those commands be run before pushing?

edublancas commented 1 year ago

@TegveerG: my bad, if this is only formatting. then that's ok, we can take this PR even with this modified files

I think let's open a separate PR for the heteroscedasticity issue