version check disable sk-eval

TegveerG commented 1 year ago

Describe your changes

Reverted to echo method, deleted vcheck.md file and any .DS_Store files

Issue number

Closes https://github.com/ploomber/contributing/issues/26

Checklist before requesting a review

[ ] Performed a self-review of my code
[ ] Formatted my code with pkgmt format
[ ] Added tests (when necessary).
[ ] Added docstring documentation and update the changelog (when needed)

:books: Documentation preview :books:: https://sklearn-evaluation--334.org.readthedocs.build/en/334/

TegveerG commented 1 year ago

@edublancas seems to be an error with the tests/test_interactive_confusion_matrix.py file. Running pytest locally fails with the following summary:

============================================= short test summary info ==============================================
FAILED tests/test_interactive_confusion_matrix.py::test_from_raw_data_with_x_pandas - TypeError: altair.vegalite.v5.schema.core.SelectionParameter() got multiple values for keyword argument 'value'
FAILED tests/test_interactive_confusion_matrix.py::test_from_raw_data_with_x_numpy[None-interactive_data_keys_expected0] - TypeError: altair.vegalite.v5.schema.core.SelectionParameter() got multiple values for keyword argument 'value'
FAILED tests/test_interactive_confusion_matrix.py::test_from_raw_data_with_x_numpy[feature_names1-interactive_data_keys_expected1] - TypeError: altair.vegalite.v5.schema.core.SelectionParameter() got multiple values for keyword argument 'value'
FAILED tests/test_interactive_confusion_matrix.py::test_from_raw_data_mixed_datatype - TypeError: altair.vegalite.v5.schema.core.SelectionParameter() got multiple values for keyword argument 'value'
===================================== 4 failed, 11 passed, 8 warnings in 2.62s =====================================

edublancas commented 1 year ago

@neelasha23, can you help us here? looks like some dependency for InteractiveConfusionMatrix got updated and it's now breaking the CI. please open an issue, describe what the problem is and I'll assign someone to work on it

Update: created a placeholder https://github.com/ploomber/sklearn-evaluation/issues/336, let's investigate why this is happening

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5338563284

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.723%

Totals
Change from base Build 5313928662:	0.0%
Covered Lines:	3557
Relevant Lines:	3878

💛 - Coveralls

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5338563284

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.723%

Totals
Change from base Build 5313928662:	0.0%
Covered Lines:	3557
Relevant Lines:	3878

💛 - Coveralls

TegveerG commented 1 year ago

Hi @edublancas, Neelasha's fix in sklearn-evaluation unblocked this issue and it works fine now. I don't see the button for requesting another review, hence commenting here

ploomber / sklearn-evaluation