Closed yafimvo closed 2 years ago
@yafimvo please fix failing tests
I think short flags should be only one character so you can chain them together eg. tar -czvf
for compressing. So maybe we use -S
if -s
is already used
good point, maybe -sd
, -S
might be a bit confusing.
Agree with Prem that it should be one character. I think some of the short flags are two characters but that was a mistake on my end. If the -s is taken we can use -S
Sent from my iPad
On 31 Aug 2022, at 11:27, Prem Netsuwan @.***> wrote:
I think short flags should be only one character so you can chain them together eg. tar -czvf for compressing. So maybe we use -S if -s is already used
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.
Alright, let's go with -S
then.
On Wed, Aug 31, 2022 at 1:57 PM Eduardo Blancas @.***> wrote:
Agree with Prem that it should be one character. I think some of the short flags are two characters but that was a mistake on my end. If the -s is taken we can use -S
Sent from my iPad
On 31 Aug 2022, at 11:27, Prem Netsuwan @.***> wrote:
I think short flags should be only one character so you can chain them together eg. tar -czvf for compressing. So maybe we use -S if -s is already used
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.
— Reply to this email directly, view it on GitHub https://github.com/ploomber/soopervisor/pull/106#issuecomment-1233246187, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYPJONNLUGF2EQAC6V3QVLV36MJ5ANCNFSM57LA2M3Q . You are receiving this because you commented.Message ID: @.***>
can we add a little note saying this was added in version 0.8.1?
also, the formatting for the link is broken: https://github.com/ploomber/soopervisor/blob/master/CHANGELOG.rst
Describe your changes
skip_docker attribute added to the export method in AbstractExporter and implemented in every exporter class (AWSBatchExporter, AirflowExporter, ArgoWorkflowsExporter, KubeflowExporter)
Issue ticket number and link
Closes #103
Checklist before requesting a review