Skip building docker image

ploomber / soopervisor

☁️ Export Ploomber pipelines to Kubernetes (Argo), Airflow, AWS Batch, SLURM, and Kubeflow.

https://soopervisor.readthedocs.io

Apache License 2.0

45 stars 18 forks source link

Skip building docker image #115

Closed yafimvo closed 2 years ago

yafimvo commented 2 years ago

Describe your changes

CHANGELOG.rst file change to CHANGELOG.md
skip_docker version note added

Issue ticket number and link

Closes #103

Checklist before requesting a review

[X] I have performed a self-review of my code
[X] I have added thorough tests (when necessary).
[X] I have added the right documentation (when needed). Product update? If yes, write one line about this update.

yafimvo commented 2 years ago

any reason for changing changelog.rst to .md? the file is in rst format

The different syntax between .md and .rst files may cause formatting issues such as broken links (like this).

I changed CHANGELOG.rst to .md since we're using .md in all our previous projects.

edublancas commented 2 years ago

Ah. There's some confusion here.

There's no need to add links to the changelog manually. Just add the changelog the entry and add the (#NUMBER) part. We have a tool that expands this into GitHub links automatically. So please revert the format to rst since this is causing a merge conflict.