Closed 94rain closed 2 years ago
Ah, great catch!
The problem is that we recently moved out the example notebook from soorgeon.
Can you edit this file locally: https://github.com/ploomber/soopervisor/blob/566d7773a3af408046d0efbdbd80ad10f77bb620/tutorials/workflow/Dockerfile#L53
and change line 53 for:
https://raw.githubusercontent.com/ploomber/soorgeon/main/examples/machine-learning/nb.py
then try again and see if it works. if it does, please submit a PR with the updated Dockerfile
I already created a PR (#90) to change the notebook url from soorgeon to ci-notebooks.
Should I really change it to https://raw.githubusercontent.com/ploomber/soorgeon/main/examples/machine-learning/nb.py
instead? This seems different from the titanic-logistic-regression-with-python
notebook.
ah no, that's ok. I merged the PR. so what you're saying is that even with the updated URL, you still see the issue, right? the one you reported in the initial comment.
ah no, that's ok. I merged the PR. so what you're saying is that even with the updated URL, you still see the issue, right? the one you reported in the initial comment.
Yeah.
ok, I took a look at the Dockerfile and the command but I cannot understand why this is failing. can you help me out?
Maybe try removing the arguments:
docker run -i -t ploomber-workflow
my guess is that one of them if causing the error
ok, I took a look at the Dockerfile and the command but I cannot understand why this is failing. can you help me out?
Maybe try removing the arguments:
docker run -i -t ploomber-workflow
my guess is that one of them if causing the error
I just ran it and the same error still exists
I am setting up Github actions to ensure this is not an issue related to my own environment.
I've set up Github actions for all docker images for the tutorials. Only the workflow tutorial has been failing. It is indeed some issue in the docker run
command and I should have fixed them now (https://github.com/ploomber/soopervisor/compare/master...94rain:soopervisor:ci_docker_image#diff-b766c191d44401f22de85349202be7177c1c8777be454ceca50727f193e265b2)
Just to confirm: Do we actually want to add the Github actions for all docker images? Is the triggering condition on: [push, pull_request]
fine?
thanks for working on this. can you open a PR just with the change that fixes the docker command?
let's tackle this first, and then we tackle the docker testing thing. I'll open an issue shortly
thanks for working on this. can you open a PR just with the change that fixes the docker command?
let's tackle this first, and then we tackle the docker testing thing. I'll open an issue shortly
Sure, I moved a little bit too fast. Just updated #95 with only changes to the tutorial.
I was following this tutorial to execute a workflow docker container on Ubuntu (logged in as the root user).
After I fixed the issue in #90, it failed while running the following step:
It produces the following error:
I don't know if there is anything wrong on my side. I don't have any mount folders.