Closed Wxl19980214 closed 2 years ago
the CI is broken, looks like some issue accessing the notebooks
@edublancas Yeah it is. I put it in the To Do list. We need a PAT in repo's secrets. Also one of the test case is failing anyway
ok so most of them pass now. but there's one that still fails look-at-this-note-feature-engineering-is-easy
. did anything change from the file we had here to the one that's being downloaded? looks like it has H1 headings now
Yeah we're on it, we introduced a feature to reject H1s, we'll change it to H2s in the notebook and that should fix it.
Just updated notebooks. The last check should pass. But still, I do think we need to put a token in to make sure it does't fail in the future. I think there's a limitation on api request for non-login request. I am asking shuyang to generate a pat to test if it works. I don't even know why it works without authentication, but it mostly because our repo is public.
lmk and I'll remove the PAT. Yeah I think it's because it's a public repo.
@idomic I left them there on purpose just in case we encounter some errors later. But I can remove it for now. It's easy fix anyway
Describe your changes
To do
1.We need to add a personal access token to the repo's secrets.
Issue ticket number and link
Closes #59 #39
Checklist before requesting a review