ploomber / soorgeon

Convert monolithic Jupyter notebooks 📙 into maintainable Ploomber pipelines. 📊
https://ploomber.io
Apache License 2.0
78 stars 20 forks source link

Refactor test command to use papermill to run notebooks #78

Closed 94rain closed 2 years ago

94rain commented 2 years ago

Describe your changes

Issue ticket number and link

Closes #6

Checklist before requesting a review

94rain commented 2 years ago

image

edublancas commented 2 years ago

How about If it's another error, show the guide for debugging notebooks? I see the link to the debugging guide was removed.

The link to the debugging docs is not applicable here. The docs show how to debug pipelines and it assumes the person is already familiar with Ploomber, here, the person has a single notebook

I moved the "Contact us for help: https://ploomber.io/community" message to a constant.

yeah, that's better

I did this approach. This still looks a bit weird.

How do you think it could be better?

idomic commented 2 years ago

@94rain ready for review?

94rain commented 2 years ago

The link to the debugging docs is not applicable here. The docs show how to debug pipelines and it assumes the person is already familiar with Ploomber, here, the person has a single notebook

I see. I removed tests for checking out how to debug notebook.

@94rain ready for review?

If the message format (screenshot above) looks fine, then yes.

edublancas commented 2 years ago

great work!