search

plooney / kretz

Apache License 2.0
11 stars 5 forks source link

altered transform docs #11

Closed gordon-n-stevenson closed 5 years ago

gordon-n-stevenson commented 5 years ago

Have adjusted the documentation of the transforms to conform to the geometry of the toroidal space as used by the transform. There were a few copy and paste issues, so I think this change clarifies what which space is being transformed into which.

I would be great if you can confirm the doc tallies with what I think the transform is doing!

plooney commented 5 years ago

The slightly confusing thing is that to transform from cartesian to toroidal you need the equations to map the toroidal space to cartesian. This is how the resample filter in ITK works. Unless I am missing something the docs seem to be correct. The equations in the docs aren't the same as those in the implementation but they shouldn't be.

gordon-n-stevenson commented 5 years ago

I see 🙈 the resample filter strikes me again. I stand corrected! Few queries I had about first dimension in toroidal being alpha but being r I the point transform. I need to understand more.

On 13 Dec. 2018 22:24, "plooney" notifications@github.com wrote:

The slightly confusing thing is that to transform from cartesian to toroidal you need the equations to map the toroidal space to cartesian. This is how the resample filter in ITK works. Unless I am missing something the docs seem to be correct. The equations in the docs aren't the same as those in the implementation but they shouldn't be.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/plooney/kretz/pull/11#issuecomment-446934700, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1YKl_-oMkcBZjSAyVYokANHTHCOqiuks5u4jjdgaJpZM4ZQqLX .