search

plopjs / plop

Consistency Made Simple
http://plopjs.com
MIT License
7.12k stars 277 forks source link

fix(engines): update engines to match top level package #403

Closed blabute closed 12 months ago

blabute commented 12 months ago

When updating to plop 4 and reading that support for Node 12, 14, and 16 was dropped, I was surprised that my Node 16 application was still able to install plop without a warning about the engine.

Updating these engines will ensure that consumers of plop will be notified on install that their version of node may not be unsupported if it is below 18.

blabute commented 12 months ago

Dunno how I missed this - thank you!

My pleasure! Thanks for merging 🤝

blabute commented 12 months ago

Looks like the workflow failed, though. Can you take a look @crutchcorn when you get a chance so we can get a new version published? 🙏

blabute commented 10 months ago

Happy holidays, @crutchcorn!

I've tried to run a few pipelines against an MR that reverts my changes but am not getting a passing action one way or the other. Are you aware of some flakiness with the tests? Happy to look into it if you are unsure.

crutchcorn commented 10 months ago

The flakiness with tests originate from my underlying test package;

https://github.com/crutchcorn/cli-testing-library

And the combination with windows (IIRC). I don't know why they happen and it's never on physical device. If you solve this (and tests are able to run on Plop 5x back-to-back without failing Windows tests) I would authentically be happy to pay a bounty of $50 for nothing if not my own sanity haha.