ploppyperson / StackMob-5

A plugin for bukkit servers, which aims to reduce the lag that the server experiences by combining several entities into a single entity.
GNU General Public License v3.0
54 stars 20 forks source link

Fire Aspect & 1.21 #292

Open Tomographix opened 1 month ago

Tomographix commented 1 month ago

Hi, The Fire Aspect doesn't seem to work on stacked mobs in 1.21.

Running:

ploppyperson commented 1 month ago

What exactly isn't working?

Tomographix commented 1 month ago

Fire Aspect is a vanilla Minecraft sword enchantment that sets the target on fire. When a mob that normally drops raw meat is killed while it is burning, or if a mob is killed in one shot, even if it is in water, it drops cooked meat.

In this situation, if you kill a stack of 200 pigs & 90% of the drops are raw porkchops when they should be 100% cooked porkchop - or at least this is how it worked prior to 1.21.

ploppyperson commented 1 month ago

I can only reproduce this when a mob is in rain. Is this the same for you?

Tomographix commented 1 month ago

Ah no, rain is actually disabled on the server. Have got a short video here on Imgur: https://i.imgur.com/EdnbjZF.mp4

ploppyperson commented 1 month ago

Yeah so after some more testing seems to be that if you kill the mob in one hit then fire aspect doesn't apply, but if there are two hits it works fine... This may be a craftbukkit bug but needs further looking into.

Temp fix would be to disable use of loot tables in config.

ploppyperson commented 1 month ago

Thanks for the bug report. There is a temp fix in cde56de, although whether this is actually a craftbukkit bug is uncertain since this is seems to be result of Mojangs changes.