plotly / Dash.jl

Dash for Julia - A Julia interface to the Dash ecosystem for creating analytic web applications in Julia. No JavaScript required.
MIT License
486 stars 41 forks source link

Add Julia test workflow #176

Closed etpinard closed 1 year ago

etpinard commented 1 year ago

As discussed in https://github.com/plotly/Dash.jl/pull/175#issuecomment-1327524286, I think it would be easier to run the Julia ] test for different Julia versions inside a Github workflow instead of inside the plotly/julia:ci docker container.

Running Julia tests inside Github workflows is fairly easy now thanks to the julia-actions organisation. This should make it much easier to maintain the list of tested Julia versions for Dash.jl. It's much easier to patch a yaml file than updating a docker image, right? :stuck_out_tongue:

I'm thinking we could also drop these lines:

https://github.com/plotly/Dash.jl/blob/f0606e07d2479fd8b5be1da4a6a59656e24acfa3/.circleci/config.yml#L30-L33

https://github.com/plotly/Dash.jl/blob/f0606e07d2479fd8b5be1da4a6a59656e24acfa3/test/ci_prepare.jl#L11

and have the CircleCI workflow be used just for the integration (percy) tests.

etpinard commented 1 year ago

Hmm, I'll need to figure out why the final step of the CircleCI workflow is failing

image

mind6 commented 1 year ago

As discussed in #175 (comment), I think it would be easier to run the Julia ] test for different Julia versions inside a Github workflow instead of inside the plotly/julia:ci docker container.

Running Julia tests inside Github workflows is fairly easy now thanks to the julia-actions organisation. This should make it much easier to maintain the list of tested Julia versions for Dash.jl. It's much easier to patch a yaml file than updating a docker image, right? 😛

I'm thinking we could also drop these lines:

https://github.com/plotly/Dash.jl/blob/f0606e07d2479fd8b5be1da4a6a59656e24acfa3/.circleci/config.yml#L30-L33

https://github.com/plotly/Dash.jl/blob/f0606e07d2479fd8b5be1da4a6a59656e24acfa3/test/ci_prepare.jl#L11

and have the CircleCI workflow be used just for the integration (percy) tests.

The github actions seem quite nice. Don't know anything about CircleCI/percy hope it works out.

etpinard commented 1 year ago

We have passing tests :tada: - merging!