Fix Percy CI tests - Githubissues

etpinard commented 1 year ago

The Percy tests are currently failing, for example in https://github.com/plotly/Dash.jl/pull/176:

If anyone seeing this has experience with Percy, your help would be much appreciated!

etpinard commented 1 year ago

Update

Now that https://github.com/plotly/Dash.jl/pull/207 is merged, the CircleCI workflow now passes and can successfully upload percy snapshots to percy.io:

But on the percy.io build page, looks like I can't approve the snapshots and we cannot reuse the "old" snapshots either.

So, looks like we'll need help from someone at Plotly in order to resolve this issue.

In the meantime, manually asserting that the screenshots look like:

is better than nothing :smile:

alexcjohnson commented 1 year ago

@etpinard I sent you an invite to percy, LMK if that unblocks you!

etpinard commented 1 year ago

Thanks @alexcjohnson !!

I can now approve the baselines and I think I got the baseline settings to work correctly with

I got a clean pass in https://percy.io/plotly/dash.jl/builds/28183626/unchanged/1566645204?browser=chrome&viewLayout=side-by-side&viewMode=new&width=1280

and I got percy to generate a diff with this patch

--- a/test/integration/base/jl_render/jltr001r_undo_redo.jl
+++ b/test/integration/base/jl_render/jltr001r_undo_redo.jl
@@ -4,7 +4,8 @@ app = dash(show_undo_redo=true)

 app.layout = html_div() do
  dcc_input(id="a"),
- html_div(id="b")
+ html_div(id="b"),
+ html_h1("SHOULD NOT WORK")
 end

https://percy.io/plotly/dash.jl/builds/28184515/changed/1566701020?browser=firefox&browser_ids=38%2C39&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=1280&widths=1280

Closing :tada: :tada: :tada:

plotly / Dash.jl

Fix Percy CI tests #177

Update