search

plotly / Dash.jl

Dash for Julia - A Julia interface to the Dash ecosystem for creating analytic web applications in Julia. No JavaScript required.
MIT License
486 stars 41 forks source link

Update test docker image #205

Closed etpinard closed 1 year ago

etpinard commented 1 year ago

Attempting to resolve https://github.com/plotly/Dash.jl/issues/186

etpinard commented 1 year ago

Inspired by https://github.com/plotly/dash/blob/dev/.circleci/config.yml, I think we might pretty close to bringing the integration tests back to life

image image

etpinard commented 1 year ago

Scratch that. We only have one failure:

image

in https://github.com/plotly/Dash.jl/blob/dev/test/integration/callbacks/jl_callback_context/jlcbcx001_modified_response.jl

which could be related to the recent HTTP update.

etpinard commented 1 year ago

:tada: :tada: the CircleCI workflow is green again

image

From https://percy.io/plotly/dash.jl/builds/28109260/changed/1563181684?browser=firefox&browser_ids=38%2C39&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=1280&widths=1280

looks like we'll need to update the snapshots on percy since we're now using python 3.9

etpinard commented 1 year ago

Ok I tried to resolve the percy tests (cc https://github.com/plotly/Dash.jl/issues/177) in the same go, but looks like even if we fallback to python 3.7 we'll need to re-approved the snapshots.

This requires special rights on percy,io, which I don't have (yet :smirk: ).

etpinard commented 1 year ago

Now in https://github.com/plotly/Dash.jl/pull/207