Attempt at bringing `gen_resources` back to life

etpinard commented 1 year ago

My attempt at updating the 18+ months old https://github.com/plotly/DashCoreResources tarball.

I do not have push rights to https://github.com/plotly/DashCoreResources, so I pushed to my fork https://github.com/etpinard/DashCoreResources, see diff.

I needed to tweak the Sources.toml in https://github.com/plotly/Dash.jl/commit/a8f15a2ba597c4a33e34c1dbce391599ce8b67df as the dash renderer is no long a separate python package.

This isn't quite sufficient though. Using the new artifacts, I get

Any help here would be much appreciated!

etpinard commented 1 year ago

In the generated DashCoreResources/resources/dash_renderer.yaml, these lines

could be telling us something :thinking:

alexcjohnson commented 1 year ago

hmm something to do with the refactoring we did with Python Dash 2.0? I didn't think that moved the renderer but maybe it had some side-effect. Anyway I gave you write access to https://github.com/plotly/DashCoreResources, if that's still useful.

etpinard commented 1 year ago

I got the resources to load properly with https://github.com/plotly/Dash.jl/pull/208/commits/56a0ae2e49ff6daf521ff4652210227e2fb58141, there might a better way to do this.

Briefly, we need to account for the differences between the old dash_renderer_deps file tree and the new one. The generated dash_renderer.yaml diff (see https://github.com/plotly/Dash.jl/pull/208#issuecomment-1590054538) get us close, but not quite to the finish line.

This results in two failing integration tests

to be continued ....

etpinard commented 1 year ago

Update

I got the integration tests to pass again :tada:

commit https://github.com/plotly/Dash.jl/pull/208/commits/6eb9c061eabe7ae7045931f18ffce3d80f2d05b7 adapts the Promise in clientside callback test as now JS Promises do work inside clientside callbacks thanks to dash#2009, released in dash v2.4.0
- It might be nice to adapt and include the other integration tests added in dash#2009 in Dash.jl while at it
commit https://github.com/plotly/Dash.jl/pull/208/commits/95d05619387a80c6fdcfb19ae881cd2c8804176f adapts the devtools prop check test suite (essential what this piece of a very large patch did in python) now that nested props are valid since dash#1763, released in dash v2.1.0

Now, the percy snapshots did generate two diffs:

which I'm not 100% sure were expected.

If any Dash.jl user is reading this, it would be nice to have some of you try out this branch in your dev environment

julia> import Pkg
julia> Pkg.add(url="https://github.com/plotly/Dash.jl", rev="bring-gen_resources-back-to-life")

thank you !!

etpinard commented 1 year ago

Now in https://github.com/plotly/Dash.jl/pull/212 - closing.

plotly / Dash.jl

Attempt at bringing `gen_resources` back to life #208

Update