handle empty children for index by id

plotly / Dash.jl

Dash for Julia - A Julia interface to the Dash ecosystem for creating analytic web applications in Julia. No JavaScript required.

MIT License

486 stars 41 forks source link

Closed BeastyBlacksmith closed 1 year ago

BeastyBlacksmith commented 1 year ago

unfortunately I missed this case in #203

etpinard commented 1 year ago

Great.

Look like you added your commit on an outdated base branch.

Would you mind rebasing your branch off the latest dev and submitting a new PR? Thanks!

BeastyBlacksmith commented 1 year ago

done

etpinard commented 1 year ago

Come to think of it. The Base.getindex(component::DashBase.Component, id::AbstractString) definition is type-piracy

Would you mind moving it (along with its tests) to DashBase.jl ?

BeastyBlacksmith commented 1 year ago

I moved that, tests will fail until https://github.com/plotly/DashBase.jl/pull/5 is merged and released

etpinard commented 1 year ago