search

plotly / Dash.jl

Dash for Julia - A Julia interface to the Dash ecosystem for creating analytic web applications in Julia. No JavaScript required.
MIT License
486 stars 41 forks source link

Adapt for DashBase v1 #223

Closed etpinard closed 1 year ago

etpinard commented 1 year ago

Requires https://github.com/plotly/DashBase.jl/pull/9, supersedes https://github.com/plotly/Dash.jl/pull/219 and will resolve https://github.com/plotly/Dash.jl/issues/221

Commit fb011f3a1aa4db0d12e61a3e31cd3d100d409e99 is the fun one, where we remove the DashBase.to_dash definitions from this repo. They are now rightfully placed in DashBase proper. This makes Dash no longer depend directly on PlotlyBase and Requires :tada:

Commit 70ec860b86fd83b2887fccad9f01cfbffd919a3a is less fun, where we need to workaround the fact that we cannot use test deps for the integration tests as the JuliaRunner (cc https://github.com/plotly/dash/pull/2573) use julia --project as its base command to boot up the Dash servers.

With commits f003ddf85dbbf0369bb39f36ab8b6a832f92b171 and https://github.com/plotly/Dash.jl/commit/421c2f4adf84b9a75536af820bcddead7738003f, we'll test graph rendering (with snapshots!) using all the DashBase extensions from now on.

etpinard commented 1 year ago

New snapshots

image

image

image

etpinard commented 1 year ago

Merging into dev.

This will be part of v1.4.0, but I'll wait about 1 week before making that release.

If anyone is willing to test drive Dash#dev in the meantime, this would be much appreciated :smile:

etpinard commented 11 months ago

This will be part of v1.4.0, but I'll wait about 1 week before making that release.

:facepalm: I forgot about this. Sorry!

I'll make the v1.4.0 release after I get back from vacation on October 2.