accept app root path as kwarg to `dash()` method

plotly / Dash.jl

Dash for Julia - A Julia interface to the Dash ecosystem for creating analytic web applications in Julia. No JavaScript required.

MIT License

486 stars 41 forks source link

accept app root path as kwarg to `dash()` method #233

Open tanmaykm opened 9 months ago

tanmaykm commented 9 months ago

Allow the app root path to be specified explicitly for the dash() method. The default is app_root_path() and does not break compatibilty.

fixes: #232

tanmaykm commented 9 months ago

CI failed in the "Install Chromedriver" step here... seems unrelated to changes in the PR?

etpinard commented 9 months ago

@tanmaykm thanks very much for this PR!

I got the tests to pass again with https://github.com/plotly/Dash.jl/pull/234, merging the latest dev into your branch and pushing again should give you a clean test run.

I'll need to double-check how app_root_path works in the python of dash before approving this PR.

etpinard commented 9 months ago

There's no app_root_path kwarg for the python Dash class

Ref: https://github.com/plotly/dash/blob/f70b3db6312c084206054cd903ee644359009486/dash/dash.py#L184-L357

We try as much as we can to have the Julia dash constructor mimic the python Dash class. So, I doubt we'll be able to accept this PR in its current form unfortunately :cry: