Open tanmaykm opened 9 months ago
CI failed in the "Install Chromedriver" step here... seems unrelated to changes in the PR?
@tanmaykm thanks very much for this PR!
I got the tests to pass again with https://github.com/plotly/Dash.jl/pull/234, merging the latest dev
into your branch and pushing again should give you a clean test run.
I'll need to double-check how app_root_path
works in the python of dash before approving this PR.
There's no app_root_path
kwarg for the python Dash
class
Ref: https://github.com/plotly/dash/blob/f70b3db6312c084206054cd903ee644359009486/dash/dash.py#L184-L357
We try as much as we can to have the Julia dash
constructor mimic the python Dash
class. So, I doubt we'll be able to accept this PR in its current form unfortunately :cry:
Allow the app root path to be specified explicitly for the
dash()
method. The default isapp_root_path()
and does not break compatibilty.fixes: #232