plotly / choreographer

MIT License
1 stars 0 forks source link

Tests are slow #116

Closed neyberson closed 2 weeks ago

ayjayt commented 3 weeks ago

starting and stopping browsers is by default slow so we need to do it separately, isolated, and in parallel, and then use a resource pool for the main tests.

please create test_process.py which only does three things:

  1. open browser
  2. getAllTargets (verify there is some targets, dont need specific verification)
  3. close browser

you can parameterize it or create separate functions for different styles of opening

async with Browser()

browser = await Browser()

and change arguments if you like with pymark.parameterize

ayjayt commented 3 weeks ago
ayjayt commented 2 weeks ago

https://pytest-asyncio.readthedocs.io/en/latest/how-to-guides/multiple_loops.html

ayjayt commented 2 weeks ago

@neyberson, still true?

neyberson commented 2 weeks ago

No, it's fine now