search

plotly / choreographer

MIT License
1 stars 0 forks source link

Add async.sleep(0) to close() and __aexit__ #120

Closed ayjayt closed 1 day ago

ayjayt commented 3 weeks ago

If the user is running close right up against python shutting down, awaiting one more event loop will allow asyncio to do cleanup and may avoid certain warnings

ayjayt commented 3 weeks ago

wait till API refactor

ayjayt commented 3 weeks ago

also can remove it from the test after this

ayjayt commented 1 day ago

I'm gonna punt this and say its the users responsibility to clean up their loops properly if they're doing some manual loop control, but will have to keep in testing since xdist... doesn't fufill the responsibility and seems to kill test processes a bit too eagerly