fix volcano margins for legend

plotly / dash-bio

Open-source bioinformatics components for Dash

https://dash-gallery.plotly.host/Portal/?search=Bioinformatics

MIT License

531 stars 192 forks source link

fix volcano margins for legend #551

Closed akmorrow13 closed 3 years ago

akmorrow13 commented 3 years ago

Closes #[issue number; if this PR doesn't address an issue, delete this line]

About

[ ] I am closing an issue
[ ] This is a new component
[x] I am adding a feature to an existing component, or improving an existing feature

Description of changes

akmorrow13 commented 3 years ago

Adjusted the margins so the plot can take up more space.

BEFORE: Screen Shot 2021-04-03 at 9 58 51 AM

AFTER: Screen Shot 2021-04-03 at 9 57 01 AM

xhluca commented 3 years ago

@alexcjohnson @HammadTheOne Any thoughts?

HammadTheOne commented 3 years ago

@alexcjohnson @HammadTheOne Any thoughts?

While it does make the margins what we want them, I'm very hesitant to modify the underlying volcano_plot component arguments directly with hardcoded values in this PR. We could also just change the styling of the parent component using CSS selectors (eg. .control-tabs) to make it more readable.

I think these arguments should be allowed to be passed in by users anyways, so I can open a separate PR that enables that and sets the current ones as defaults. I'll link it to this PR once it's opened.

HammadTheOne commented 3 years ago

PR for VolcanoPlot updates is opened here: https://github.com/plotly/dash-bio/pull/554

Once that's merged, we'll be able to pass in arguments for the Layout of the figure to set margin, height, width, or any other key referenced here.

akmorrow13 commented 3 years ago

Closing in favor of https://github.com/plotly/dash-bio/pull/554