search

plotly / dash-canvas

An interactive image editing component for Dash
https://dash.plot.ly/canvas
Other
84 stars 26 forks source link

MAINT: Add redo button. #26

Closed jvkersch closed 5 years ago

jvkersch commented 5 years ago

closes #20

This adds a redo button to the tools that are listed below the canvas. I've also made an attempt at putting together an integration test with Dash to check the behavior of the undo/redo buttons.

Along the way, I deleted test_usage.py, since it used the now-deprecated pytest-dash plugin, which conflicts with the standard dash[testing] package. I assumed its functionality would be a subset of the functionality in my integration test, but please let me know if it needs to be restored.

emmanuelle commented 5 years ago

Awesome @jvkersch thanks a lot! I have been travelling for a month so I just saw your PR, will be getting back to you soon.

emmanuelle commented 5 years ago

Looks good to me, thanks! Could you please just replace dash by dash[testing] in requirements.txt? Then I'll merge.

jvkersch commented 5 years ago

Could you please just replace dash by dash[testing]

Done! Thanks for the review!

emmanuelle commented 5 years ago

Thanks a lot, merging! Now let's have CircleCI be happy again ;-)