Closed wilzbach closed 5 years ago
Anyhow, I'm guessing that committing the generated files into git has the motivation that it simplifies deployment to e.g. Heroku?
Yeah, we commit the build files for a couple of reasons:
git clone
the project and then directly import
the library. This is helpful for reviews and prereleases as it reduces the friction for community users to try out the library or different branches.These things are pretty opinionated (it's uncommon to commit build files) but we've found that it works well for our own development teams. You're welcome to modify this process yourself in your own components, but I think I'd like to keep this boilerplate representative of our own internal processes.
Hi there,
So I was just interested whether there's a reasoning behind committing the auto-generated files in
my_dash_component
into git and not adding them to the.gitignore
? And subsequently whether you would accept a PR to the.gitignore
for this? (Though it probably makes sense to wait for https://github.com/plotly/dash-component-boilerplate/pull/14 if that PR will be merged in the near future.)Anyhow, I'm guessing that committing the generated files into git has the motivation that it simplifies deployment to e.g. Heroku?
Though for Heroku it's easy to add multiple buildpacks, e.g.
The only "tricky" bit is to split up the
build:py
into a step that can be run during the nodejs build stage and one that can be run later during the Python build stage: