search

plotly / dash-component-boilerplate

Get started creating your own Dash components here.
266 stars 182 forks source link

Extra package.json? #30

Open nicolaskruchten opened 5 years ago

nicolaskruchten commented 5 years ago

I think that the second package.json is exteraneous, the one at /{{cookiecutter.project_shortname}}/{{cookiecutter.project_shortname}}/package.json.

It's being read from setup.py but I think that setup.py should read the /{{cookiecutter.project_shortname}}/package.json instead, no?

T4rk1n commented 5 years ago

Actually, there's no need to read the package.json in setup.py, should just take the name from the cookiecutter variable. There's also an issue with reading the package.json on centos: https://github.com/plotly/dash-table/pull/184

nicolaskruchten commented 5 years ago

It's actually really nice that setup.py reads the current version from package.json ...

T4rk1n commented 5 years ago

Oh I missed that, yea just read the root then and cast str(package_name).