plotly / dash-component-boilerplate

Get started creating your own Dash components here.
269 stars 182 forks source link

external url is incorrect #36

Closed chriddyp closed 5 years ago

chriddyp commented 5 years ago
'external_url': 'https://unpkg.com/{0}@{1}/{0}/{0}.min.js'.format(
__name__, __version__),

It should be

'external_url': 'https://unpkg.com/{0}@{2}/{1}/{1}.min.js'.format(
package_name, __name__, __version__),

where package_name is the hyphenated name of the NPM package e.g. dash-core-components.

We had to fix this recently in dash-table here: https://github.com/plotly/dash-table/commit/d52cf5ca91306c41680ea2751a0f92f721dae0b6#diff-ec168dc4b8b00393c6a22fc4bf118890