search

plotly / dash-component-boilerplate

Get started creating your own Dash components here.
269 stars 182 forks source link

Generate dash component cli #40

Closed T4rk1n closed 5 years ago

T4rk1n commented 5 years ago

Change the build:py command to use the combined extract-meta.js and class file generation.

T4rk1n commented 5 years ago

Also, it looks like there is a lot of code repeated in the circleci config. Can there be a template for all steps excluding the last, a template for the 2.7 and 3.6 tests, then an extra step for the 3.7 build + test, then mix + match to 🐫

Can't override only parts of steps so they have to be repeated. The 3.7 step build the components externally to run test/test_usage.py, I couldn't test the actual build:all command in the generation tests so I thought about this one. Both tests perform project generation & build, just different build method. Not sure we need to duplicate the tests on all python versions, as long as each one is tested in a way.

rmarren1 commented 5 years ago

Oh ok, did not know YAML doesn't allow merging lists :cry:. Looks good after the changes in dash

rmarren1 commented 5 years ago

:dancer: