search

plotly / dash-component-boilerplate

Get started creating your own Dash components here.
276 stars 184 forks source link

Remove react and reactDOM from dependencies. #41

Closed T4rk1n closed 6 years ago

T4rk1n commented 6 years ago

They are peerDependencies served by dash and included in the _js_dist of dash-renderer.

Closes #39

nicolaskruchten commented 6 years ago

I think they do need to be in devDependencies tho no?

T4rk1n commented 6 years ago

I don't know, I don't need them when developing from pycharm, maybe it's different with other editors ? I mean I get a warning that it's not installed but I still get auto completion.

In dcc, they are only peerDependencies.

valentijnnieman commented 6 years ago

@T4rk1n We're fixing that in https://github.com/plotly/dash-core-components/pull/373 though. They should be in devDependencies, since the Demo and unit tests are using React.

T4rk1n commented 6 years ago

@valentijnnieman Right

bpostlethwaite commented 6 years ago

@T4rk1n if you don't have React in dev-deps how will this line work? https://github.com/plotly/dash-component-boilerplate/blob/master/%7B%7Bcookiecutter.project_shortname%7D%7D/src/demo/App.js#L2

T4rk1n commented 6 years ago

@bpostlethwaite I moved react from peerDependencies to devDependencies.

bpostlethwaite commented 6 years ago

:see_no_evil: apparently I have forgotten how to read a diff

:dancer: