Slightly reword {{cookiecutter.component_name}}.react.js

plotly / dash-component-boilerplate

Get started creating your own Dash components here.

269 stars 182 forks source link

Slightly reword {{cookiecutter.component_name}}.react.js #73

Closed mkcor closed 5 years ago

mkcor commented 5 years ago

Hi @Marc-Andre-Rivet,

This change follows from discussion https://github.com/plotly/dash-bio/pull/363/#discussion_r289793522.

I have drawn from @shammamah's suggestion but included less, noticing that it would be redundant with: https://github.com/plotly/dash-component-boilerplate/blob/64406a8ecec85da56b40e930d48fa66d1a3b309c/%7B%7Bcookiecutter.project_shortname%7D%7D/src/lib/components/%7B%7Bcookiecutter.component_name%7D%7D.react.js#L23-L28

alexcjohnson commented 5 years ago

@mkcor I'm going to update boilerplate - including its failing tests - to dash 1.0, react 16, etc etc, in a separate PR. After that I'll merge those changes in here and it should pass again so we can merge this one.