search

plotly / dash-component-boilerplate

Get started creating your own Dash components here.
266 stars 182 forks source link

update to dash 1.0, plus R build #75

Closed alexcjohnson closed 4 years ago

alexcjohnson commented 5 years ago

closes #29 Updates tests here to use dash.testing, and more standardized build commands.

Adding R support turned out to be a lot simpler than #72 made it look - basically, adding in r_prefix and using it in the dash-generate-components call means it all just works ™️ - I added some tests that the right files (R and otherwise) are present after building.

This is ready for review, but should not be merged until https://github.com/plotly/dash/pull/801 is merged and released so we can point to a released version of dash in the various requirements.txt files.

bcliang commented 5 years ago

Please consider updating package.json with upgraded devDependency eslint to 5.16.0. The main thing here is that it closes a vulnerability in js-yaml@3.13.0

  "devDependencies": {
...
    "eslint": "^5.16.0",
...
  },
alexcjohnson commented 5 years ago

Please consider updating package.json with upgraded devDependency eslint to 5.16.0

Now eslint is up to v6. Updated all of package.json, and the necessary dash changes have been released so we use that as well. @byronz ready for review.