search

plotly / dash-component-boilerplate

Get started creating your own Dash components here.
276 stars 184 forks source link

Fix filename in setup.py #78

Closed LuAPi closed 5 years ago

LuAPi commented 5 years ago

Running python setup.py sdist on a project that's been copied with cookiecutter doesn't work because it can't find package.json in the subdirectory named after the project.

I'm not actually sure if this is the correct fix because there are two identical files in a repo setup by cookiecutter:

./package.json
./{{cookiecutter.project_shortname}}/package-info.json

I wasn't totally sure whether to use this fix:

with open(os.path.join('{{cookiecutter.project_shortname}}', 'package-info.json')) as f:

or this one:

with open('package.json') as f:

Both seem to work.

alexcjohnson commented 5 years ago

Closes #81 (the piece of it that wasn't closed by #86)