search

plotly / dash-core-components

OBSOLETE: now part of https://github.com/plotly/dash
https://dash.plotly.com
MIT License
271 stars 145 forks source link

[breaking change] Replace checkbox and radio items with a skinnable version #155

Open chriddyp opened 6 years ago

chriddyp commented 6 years ago

I wish that the checkboxes and radio items were customizable. Unfortunately, the background color and styling of the checkboxes and radio circles themselves are not customizable, they are browser specific.

https://github.com/luqin/react-icheck has a nice set of customizable radio items and checkboxes that I think we should use instead of our html default ones.

Unfortunately, this would be a breaking change as anyone's CSS that modifies the existing checkboxes would likely no longer work.

Perhaps we could keep the old version around with a tag like render_as_html=True to ease the pain of anyone who is upgrading the library to access some other feature.

ned2 commented 6 years ago

Another option could be to create some kind of component archive package, where old versions of components go when they have been swapped out for a different JS component. Users wanting the old behaviour would then have to install a different module and do from dash_archived_components import Checklist.

It's a little bit more work for people wanting the old behavior, but a) I wonder how large the population of people who have styled checkboxes are, and b) it's simpler from the perspective of maintaining the continuing core components code.

klnrdknt commented 4 years ago

Has there been an update on this? Does the current inputStyle of the checkbox expose the color of the tick?