Some components don't render className, id, or style

[rmarren1]

Doesn't render id

These components do not actually add the id prop to the page

• [ ] Upload
• [ ] DateRangePicker
• [ ] DatePickerSingle
• [ ] Markdown (Doesn't actually render in underlying component)
• [ ] Slider (Doesn't actually render in underlying component)

Has className prop that is not used

These components have a className prop, but it does not actually do anything

• [ ] Dropdown
• [ ] RangeSlider
• [ ] Slider

[T4rk1n]

I think there's a couple more component that are either missing className, id or style, we should take a look over all the components and ensure they all use them.

[rmarren1]

ConfirmDialog is missing style and className, but is it actually possible to style that alert menu?

[T4rk1n]

no

[valentijnnieman]

The Dropdown uses className and other props like style here, on line 98:

    {...omit(['fireEvent', 'setProps', 'value'], this.props)}

it uses the spread operator to attach all the props except those in the omit

[valentijnnieman]

Same goes for the Input. Are there any other components you've found that might miss any props? Otherwise I think we can close this issue.

[T4rk1n]

@valentijnnieman It gives those props to ReactDropdown which doesn't use it.

[T4rk1n]

I definitely remember having to wrap some components with a div just so I could add an id or className to a component that will actually be used (like in a integration test the component with an id selenium was failing to find because it wasn't actually used in render).

[rmarren1]

I was trying to make it inline, but I guess you need to set this with the style attribute since there is no className set in the wrapper

[valentijnnieman]

Ah I see, yeah, you're totally right. https://github.com/bvaughn/react-virtualized-select there's a style prop on that component but no className or id or other. We could wrap those components in a div which takes those props I guess, although for className that would not really be what you'd expect. For the Dropdown I guess the only real fix would be to use another dropdown component that is more customizable with CSS, or write one ourselves.

[rmarren1]

I'll just look through all the components and add what I find to the top level.

[valentijnnieman]

The Tab component should render it's props, including id, look in the EnhancedTab component in Tabs.react.js @rmarren1

[rmarren1]

@valentijnnieman Oh okay, I see your comment explaining that in Tabs now.