plotly / dash-core-components

OBSOLETE: now part of https://github.com/plotly/dash
https://dash.plotly.com
MIT License
270 stars 147 forks source link

Re-add new tooltip component #982

Closed xhluca closed 2 years ago

xhluca commented 2 years ago

This is an updated attempt for: https://github.com/plotly/dash-core-components/pull/940

Note #941 was also added to this PR in https://github.com/plotly/dash-core-components/pull/982/commits/6a18fd9845e510b669aae06c87f0bacda3bbed49

Related:

TODOs for demo:

alexcjohnson commented 2 years ago

@xhlulu please drop package-lock.json from this PR, since you aren't updating package.json. If you do change package.json, note that dash core is now using node 16 / npm 7

xhluca commented 2 years ago

@xhlulu please drop package-lock.json from this PR, since you aren't updating package.json. If you do change package.json, note that dash core is now using node 16 / npm 7

Sure. I removed the commit that added package-lock.json and did a force push

xhluca commented 2 years ago

@alexcjohnson am I supposed to commit NAMESPACE changes as well?

xhluca commented 2 years ago

@alexcjohnson I feel this PR is ready for review. A few questions for review:

alexcjohnson commented 2 years ago

Closing - will remake shortly in the monorepo